Simplify TypeToString and restrict usage to specific use cases#170
Merged
Conversation
pgeier
force-pushed
the
feature/simplify-type-to-string
branch
from
bdfec60 to
d3b16fb
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #170 +/- ##
========================================
Coverage 56.60% 56.60%
========================================
Files 318 316 -2
Lines 20500 20490 -10
Branches 1569 1569
========================================
- Hits 11603 11598 -5
+ Misses 8897 8892 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pgeier
force-pushed
the
feature/simplify-type-to-string
branch
from
d3b16fb to
eff26fc
Compare
dsarmany
approved these changes
Oct 8, 2025
pgeier
force-pushed
the
feature/simplify-type-to-string
branch
from
eff26fc to
f5f0a14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The usage of
util/TypeToString.his restricted to multio and will not be used in mars2grib and anything that is about to get migrated to metkit.After discussion on moving TypeToString to eckit (ecmwf/eckit#225), the decision is to restrict it to specific use-cases.
Its not used in
datamod/coreanymore, only for Metadata handling and operations on MioGribHandling - the latter is going to be refactored anyway.Some format changes sneaked in.
Contributor Declaration
By opening this pull request, I affirm the following:
🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-170