Skip to content

[2531] Require geoinfo_channels for obs streams#2534

Open
vhertel wants to merge 1 commit into
ecmwf:developfrom
vhertel:vhertel/develop/2531-obs-geoinfo-position
Open

[2531] Require geoinfo_channels for obs streams#2534
vhertel wants to merge 1 commit into
ecmwf:developfrom
vhertel:vhertel/develop/2531-obs-geoinfo-position

Conversation

@vhertel

@vhertel vhertel commented Jun 22, 2026

Copy link
Copy Markdown

Description

When a stream config does not specify geoinfo_channels, data_reader_obs.py falls back to inferring them by position: it takes the columns between lon and the first obsvalue column (line 90). This only matches if the Zarr is laid out with an order of [coords][geoinfo][obsvalue], which is not consistent with some obs datasets.

This PR removes the positional inference and instead requires geoinfo_channels to be set explicitly.

Issue Number

Closes #2531

Checklist before asking for review

  • I have performed a self-review of my code
  • My changes comply with basic sanity checks:
    • I have fixed formatting issues with ./scripts/actions.sh lint
    • I have run unit tests with ./scripts/actions.sh unit-test
    • I have documented my code and I have updated the docstrings.
    • I have added unit tests, if relevant
  • I have tried my changes with data and code:
    • I have run the integration tests with ./scripts/actions.sh integration-test
    • (bigger changes) I have run a full training and I have written in the comment the run_id(s): launch-slurm.py --time 60
    • (bigger changes and experiments) I have shared a hegdedoc in the github issue with all the configurations and runs for this experiments
  • I have informed and aligned with people impacted by my change:
    • for config changes: the MatterMost channels and/or a design doc
    • for changes of dependencies: the MatterMost software development channel

@github-actions github-actions Bot added the bug Something isn't working label Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Inconsistent geoinfo position in obs data

1 participant