Skip to content

[2320] Fix feedback when user tries to reconnect Actor's edge#2335

Open
jerome-obeo wants to merge 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/fix/disable_reconnect_tool_on_actor_edge
Open

[2320] Fix feedback when user tries to reconnect Actor's edge#2335
jerome-obeo wants to merge 1 commit into
eclipse-syson:mainfrom
jerome-obeo:jgo/fix/disable_reconnect_tool_on_actor_edge

Conversation

@jerome-obeo

@jerome-obeo jerome-obeo commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

#2320

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@jerome-obeo jerome-obeo force-pushed the jgo/fix/disable_reconnect_tool_on_actor_edge branch from 7374878 to cc69d8e Compare July 3, 2026 14:30
@jerome-obeo jerome-obeo changed the title Jgo/fix/disable reconnect tool on actor edge [2320] Fix feedback when user tries to reconnect Actor's edge Jul 3, 2026
@AxelRICHARD AxelRICHARD added this to the 2026.7.0 milestone Jul 3, 2026
@AxelRICHARD AxelRICHARD linked an issue Jul 3, 2026 that may be closed by this pull request
return otherEnd;
}

public Element reconnectTargetNestedActorEdge(Element self) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please always add javadoc on public methods

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

*** Elements without a name and an owned reference subsetting display only the reference subsetting name.
*** Elements without a reference subsetting display their name.
** Fix the broken `New Interface` tool icon.
** Add an explicit warning message when user tries to reconnect one Actor's edge to another Actor.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edge => graphical edge

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Bug: eclipse-syson#2320
Signed-off-by: Jerome Gout <jerome.gout@obeosoft.com>
@jerome-obeo jerome-obeo force-pushed the jgo/fix/disable_reconnect_tool_on_actor_edge branch from cc69d8e to ddec3b0 Compare July 3, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error on actor reconnection

2 participants