fix: connection interface end names dropped on textual SysML export#2275
Conversation
|
Hello, Thank you for providing this PR. Could you please add an entry to the CHANGELOG as required by the PR template? Thank you again, Regards, |
|
You also need to follow this rule https://doc.mbse-syson.org/syson/v2026.5.0/developer-guide/index.html#_contribute_a_change_in_the_codebase about the commit message. Thank you |
|
Hello @mvanhorn, do you plan to take into account my remarks and fix the PR? |
|
Hello @mvanhorn, if you do not plan to fix this PR, do you allow me to push my own PR based on your work? |
c4f1dcc to
13d9219
Compare
|
Apologies for the slow reply, and yes - I intend to finish this PR. Both remarks are addressed in 13d9219: added the #2264 entry to the CHANGELOG Bug fixes section, and reworded the commit to the [2264] convention from the developer guide. The ECA signature is in progress on my side - I'll confirm here once it's done. Thanks for your patience. |
13d9219 to
5590e12
Compare
…port Bug: eclipse-syson#2264 Signed-off-by: Matt Van Horn <mvanhorn@gmail.com>
5590e12 to
7540678
Compare
|
ECA is signed and the eclipsefdn/eca check is now green (I re-authored the commit with my registered Eclipse account email). That should be everything from your list: CHANGELOG entry, commit message convention, and the ECA. Ready for review whenever you are. |
PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW
Interface-type connections now serialize their two ends when exporting to textual SysML, producing
connection interface1 connect heater.socket to outlet;instead ofconnection interface1 connect to ;. #2264 (@AxelRICHARD acknowledged) reported that the textual export drops the end references for interface connections while Flow connections were unaffected, which pointed at a divergent branch in the connection-end serialization path. InSysMLElementSerializer, the interface-connection case did not emit the qualified end names the way the working flow branch does, so theconnect <end1> to <end2>form came out empty; the fix resolves and emits each end's qualified feature name on that path. A serializer test covers an interface connection between two ports and asserts the exported text carries both qualified end names, with the existing flow-connection serialization unchanged.Fixes #2264
ECA: this contribution requires an Eclipse Contributor Agreement sign-off, which the eca bot will verify against the commit author.
Auto review
Project management
priority:andpr:labels been added? (maintainer-side)Changelog and release notes
CHANGELOG.adocbeen updated? (defer to maintainer for the target release file)Key highlights? (not a key change)Documentation
Tests