Show info about missing permission on AccessForbiddenException#416
Open
rogersteblerbsi wants to merge 1 commit into
Open
Show info about missing permission on AccessForbiddenException#416rogersteblerbsi wants to merge 1 commit into
rogersteblerbsi wants to merge 1 commit into
Conversation
matthiaso
approved these changes
Jun 30, 2026
| throw new AccessForbiddenException(TEXTS.get("YouAreNotAllowedToReadThisData")); | ||
| if (!ACCESS.check(new ReadCompanyPermission())) { // <1> | ||
| throw new AccessForbiddenException(TEXTS.get("YouAreNotAllowedToReadThisData")) | ||
| .withPermission(ReadCompanyPermission.class); |
Member
There was a problem hiding this comment.
Maybe also change documentation here:
scout.docs/docs/modules/technical-guide/pages/common-concepts/security.adoc
Lines 186 to 193 in 2f4d9af
And add migration notes for users?
On a permission check an AccessForbiddenException is thrown. A message is shown to the user with a message like "You are not authorized to execute this action". But the user does not know which permission is missing. This change adds an error code to the error popup on an AccessForbiddenException to give the user a hint which permission is missing. 326455
cfdc72a to
ee34f98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a permission check an AccessForbiddenException is thrown. A message is shown to the user with a message like "You are not authorized to execute this action". But the user does not know which permission is missing.
This change adds an error code to the error popup on an AccessForbiddenException to give the user a hint which permission is missing.
326455