Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 87 additions & 0 deletions docs/modules/releasenotes/partials/release-notes-26.2.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -94,3 +94,90 @@ This is useful for composite fields that don't have its own empty state like `Gr

To influence or disable the computation of the `empty` property, you can set the property `checkEmpty` or override the method `_computeEmpty()`.
Please see the JsDoc of the `FormFieldModel.checkEmpty` for details.

== abortableContext (Scout JS)

When working with rest requests often there is the need to abort previously created requests again.
As typically all requests made using Scout JS are created using `ajax` the developer does not have access to the abortable call and therefore, is unable to use e.g. an `AbortController` to abort these calls.
To address this issue the `abortableContext` was introduced. With this one can run a callback in the context of an `AbortController`.
All abortable elements that are registered while this context is present may than be aborted using the `AbortController`.
Comment on lines +102 to +103

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To address this issue the abortableContext was introduced. It allows code to be executed within the scope of an AbortController.

In addition, all calls created using the `ajax` utility auto register themselves in the current context if there is one.

[source,typescript,opts=novalidate]
----
protected async _loadFooAndBarAbortable(id: string | number, abortController: AbortController): Promise<{ foo: object, bar: object }> {
return await abortableContext.runInContext(
() => this._loadFooAndBar(id),
abortController
);
}

protected async _loadFooAndBar(id: string | number): Promise<{ foo: object, bar: object }> {
// if run inside an abortableContext the ajax calls are auto registered
const fooPromise = ajax.getDataObject(`api/foo/${id}`);
const barPromise = ajax.getDataObject(`api/bar/${id}`);

return {
foo: await fooPromise,
bar: await barPromise
};
}
----

Other abortables can be registered in the current context using `abortableContext.registerAbortableInCurrentContext(abortable)`.
If one creates a new abortable context while running inside another abortable context, the inner context is registered in the outer one to ensure that the inner context is aborted when the outer context is aborted.

[source,typescript,opts=novalidate]
----
const outerController = new AbortController();
abortableContext.runInContext(
() => {
const innerController = new AbortController();
abortableContext.runInContext(
() => {
const innerAbortable = new MyAbortable();
abortableContext.registerAbortableInCurrentContext(innerAbortable);
},
innerController
);
},
outerController
);

// aborts the innerController and therefore the innerAbortable as well
outerController.abort();
----

== PageWithTable: abortable loading (Scout JS)

The `PageWithTable` now supports abortable loading. In order to support this the `PageWithTable` creates an `abortableContext` to run its `_loadTableData(searchFilter)` in.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: To support this, PageWithTable runs _loadTableData(searchFilter) within an abortable context.

For a typical implementation where data is loaded via rest, the call is registered automatically.

[source,typescript,opts=novalidate]
----
protected override _loadTableData(searchFilter: any): JQuery.Promise<any> {
return ajax.postDataObject('api/foo/list', this._withMaxRowCountContribution(searchFilter));
}
----

As only synchronously created calls are registered automatically, implementations that make several calls subsequently must create new abortable contexts for each asynchronously created rest call to ensure all calls are aborted correctly.
If this is not done, the `PageWithTable` will still behave correctly, i.e. will not show resulting data when loading was aborted.
So creating a new abortable context for a subsequent call is not necessary for the user experience but prevents unnecessary calls being made.
To create such a new abortable context all implementations of `PageWithTable` can use the protected member `_abortController`.

[source,typescript,opts=novalidate]
----
protected override _loadTableData(searchFilter: any): JQuery.Promise<any> {
return $.when(this._loadTableDataAsync(searchFilter));
}

protected async _loadTableDataAsync(searchFilter: any): Promise<any> {
const abortController = this._abortController;
const searchRestrictions = await ajax.postDataObject('search-api/util/build-search-restrictions', this._withMaxRowCountContribution(searchFilter));
const foos = await abortableContext.runInContext(
() => ajax.postDataObject('api/foo/list', {searchRestrictions}),
abortController
);
return foos;
}
----