Move the Project Explorer performance test to the performance bundle - #4259
Merged
vogella merged 1 commit intoAug 20, 2026
Merged
Conversation
The navigator test bundle carried a PerformanceTest that no suite ran: it was commented out of NavigatorTestSuite for bug 264449 and reported its timings with System.out.println, so it could neither fail nor be compared. It belongs with the other performance tests, which report through UIPerformanceTestUtil since they were migrated off the performance database. ProjectExplorerPerformanceTest keeps the project deletion and label provider mapping scenarios, measures each of them over several rounds rather than once, and drops the dependency on NavigatorTestBase. It adds testRemoveFilesOfCollapsedProject, which removes files that have no item in the tree because their project was never expanded. That is what a delete below a collapsed project comes down to, and it is the case where the viewer has to ask the content service for a parent. With 2000 files ten folders deep it reports 3.5ms against 18.6ms when the viewer walks the whole ancestor chain instead of asking for the immediate parent.
Contributor
Contributor
Author
|
Test code which is not affected by the release freeze rule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The navigator test bundle carried a PerformanceTest that no suite ran: it was commented out of NavigatorTestSuite for bug 264449 and reported its timings with System.out.println, so it could neither fail nor be compared against anything. It belongs with the other performance tests, which report through UIPerformanceTestUtil since they were migrated off the performance database.
ProjectExplorerPerformanceTest keeps the project deletion and label provider mapping scenarios, measures each of them over several rounds rather than once, and no longer depends on NavigatorTestBase. It also adds testRemoveFilesOfCollapsedProject, which removes files that have no item in the tree because their project was never expanded. That is what a delete below a collapsed project comes down to, and it is the case where the viewer has to ask the content service for a parent, which nothing covered before.