Combine the tree viewer performance tests into one class - #4258
Merged
vogella merged 1 commit intoAug 20, 2026
Merged
Conversation
TreeAddTest, FastTreeTest, ShrinkingTreeTest and TreeViewerRefreshTest each measured one aspect of the same widget in its own class, which the old performance database needed because a class was the unit it reported on. Now that the tests print their own timings the split only spreads one subject over four files and a shared base class. TreeViewerPerformanceTest carries all of the scenarios. The additions that FastTreeTest repeated ten times with a removal in between become a round count on the shared measuring method, and the two refresh scenarios keep their content providers, so the measurements are the ones the separate classes took. TreeTest is gone, its content provider now sits with the test that uses it.
Contributor
Contributor
Author
|
Test code which is not affected by the release freeze rule |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TreeAddTest, FastTreeTest, ShrinkingTreeTest and TreeViewerRefreshTest each measured one aspect of the same widget in a class of its own, which the old performance database needed because a class was its reporting unit. Now that these tests print their own timings, the split only spreads one subject over four files and a shared base class.
TreeViewerPerformanceTest carries all of the scenarios. The additions that FastTreeTest repeated ten times with a removal in between become a round count on the shared measuring method, and the two refresh scenarios keep their own content provider and comparator setup, so the measurements are the ones the separate classes took. TreeTest is gone and its content provider now sits with the test that uses it.