-
Notifications
You must be signed in to change notification settings - Fork 5
Add CPS raw2Sv realtime processing flow #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LOCEANlloydizard
merged 9 commits into
echostack-org:main
from
LOCEANlloydizard:update-raw2sv-for-cps
Aug 27, 2026
Merged
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bdcef4e
Add CPS Flow last additions
eliascapriles-NOAA 82aa932
Fix typo
eliascapriles-NOAA 5fd9c95
Add CPS raw2Sv realtime processing flow
LOCEANlloydizard 209d8a5
fix imports and lint issues
LOCEANlloydizard 2b396d8
fix raw watcher event emission
LOCEANlloydizard fe02a5e
small patch
leewujung 1d7a433
Merge branch 'Add_cps_flow_edits' into update-raw2sv-for-cps
eliascapriles-NOAA dd53edc
Revert "Merge branch 'Add_cps_flow_edits' into update-raw2sv-for-cps"
LOCEANlloydizard 1a547d2
finalize CPS polling and deployment behavior
LOCEANlloydizard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,7 +9,7 @@ | |
|
|
||
| from prefect import flow, get_run_logger | ||
|
|
||
| from echodataflow.utils.utils import round_up_mins, get_slice_start_end_times | ||
| from echodataflow.utils.utils import get_slice_start_end_times | ||
|
|
||
|
|
||
| @flow() | ||
|
|
@@ -256,9 +256,17 @@ def flow_update_cache_CPS( | |
| # Find latest completed CPS transect | ||
| # ----------------------------------------------------- | ||
|
|
||
| def _transect_number(path: Path) -> int: | ||
| return int( | ||
| path.name | ||
| .replace("transect_", "") | ||
| .replace("_CPS.zarr", "") | ||
| ) | ||
|
|
||
|
|
||
| cps_files = sorted( | ||
| path_CPS.glob("transect_*_CPS.zarr"), | ||
| key=lambda path: path.stat().st_mtime, | ||
| key=_transect_number, | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe collapse lines like these throughout the codebase to a single line to avoid excessive vertical splitting
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. done! |
||
| ) | ||
|
|
||
| if not cps_files: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is a duplicate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure what you mean - it's the only entry in the registry?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there’s another one at L85! Not sure when it was added, my bad.. I think I added it at some point!