Add cps flow edits - #185
Conversation
LOCEANlloydizard
left a comment
There was a problem hiding this comment.
thx @eliascapriles-NOAA! a few things I noticed while going through the changes:
-
we should we keep the parameters recipe-driven and avoid hard-coding the Blackwell/CPS values in the flow (channel=1, q=0.95, -50, wtheta=7, wphi=7, etc.)? If these are new parameters we want to use, I think it would be better to expose them in the flow and set them through the deployment recipe, so the processing stays configurable!
-
could we also preserve the original calibrated ds["Sv"] and store the convolved/processed field separately? That way the final mask can still be applied back to the original Sv
-
after the convolution and background-noise removal, I think sv_for_cps should be rebuilt from the processed variable. At the moment it looks like it may still refer to the version created before those steps?
Maybe you could also try deploying/testing this version directly using the CPS deployment recipe in echodataflow-recipes, together with the deployment instructions in the README. That should make it easier to check whether you're happy with the resulting CPS output? cheers!
|
Hey @LOCEANlloydizard totally agree with these changes let me get on that, and fix the problems up. I wanted to crank out a quick solution at first, but let me get on fixing those up ! |
Update raw2sv for cps
…-NOAA/echodataflow into Add_cps_flow_edits
Main edits: