bump dependencies for compatibility with python interpreter 3.13 - #83
Merged
Merged
Conversation
lxml 4.4 is incompatible with python 3.13. lxml 5.1 seems to be compatible with all python interpreter versions that ebu_adm_renderer intends to support. Signed-off-by: Daniel Struebig <dstr@bang-olufsen.dk>
According to pyproject.toml, ebu_adm_renderer requires 3.8 or greater. Having tox run with 3.6 and 3.7 then seems unnecessary. Signed-off-by: Daniel Struebig <dstr@bang-olufsen.dk>
Signed-off-by: Daniel Struebig <dstr@bang-olufsen.dk>
Collaborator
|
All looks fine and builds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
lxmldependency version 4.4 is incompatible with 3.13. Let's bump it to 5.1 instead which maintains compatibility with up to 3.8. I ran tox locally and all tests in all environments passed.pyproject.toml,ebu_adm_rendererneeds 3.8 as a minimum anyways.