Add e2fsprogs-extra to alpine-base - Fixes #132 - #140
Open
torrancew wants to merge 1 commit into
Open
Conversation
Alpine packages `resize2fs` in `e2fsprogs-extra`, going back at least as far as Alpine 3.16: ref: https://pkgs.alpinelinux.org/contents?file=resize2fs&path=&name=&branch=v3.16 Some other parts of the repo already document this: - `host/src/alpine/utils.rs` - `docs/custom-images.md` I left a single comment un-changed, as (best I could tell), it was in a distro-agnostic context: - `host/src/vm/core.ts:1614` I left `host/src/build/container.ts` unchanged, as to the best of my understanding, the container there does not implicitly hit any resize paths. Happy to update this if I'm wrong, to maintain consistency, etc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alpine packages
resize2fsine2fsprogs-extra, going back at least as far as Alpine 3.16:ref: https://pkgs.alpinelinux.org/contents?file=resize2fs&path=&name=&branch=v3.16
Some other parts of the repo already document this:
host/src/alpine/utils.rsdocs/custom-images.mdI left a single comment un-changed, as (best I could tell), it was in a distro-agnostic context:
host/src/vm/core.ts:1614I left
host/src/build/container.tsunchanged, as to the best of my understanding, the container there does not implicitly hit any resize paths. Happy to update this if I'm wrong, to maintain consistency, etc.Contribution Agreement
Please ensure this PR follows the guidelines in
CONTRIBUTING.md.Note from @torrancew: This repo does not contain a
CONTRIBUTING.md. I have read, understood, and applied the relevant sections from theearendil-works/piCONTRIBUTING.mdin its absence.By submitting this pull request, I confirm the following:
I understand that the entity Earendil Inc. (incorporated in the state of Delaware in 2025) needs some rights from me in order to utilize my contributions in this PR. As a contributor I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Earendil Inc. can use, modify, copy, and redistribute my contributions, under Earendil Inc.'s choice of terms.