Prevent unhandled rejections in writeGuestFile and deleteGuestFile, as in readGuestFileStream - #136
Open
maxhully wants to merge 1 commit into
Open
Prevent unhandled rejections in writeGuestFile and deleteGuestFile, as in readGuestFileStream#136maxhully wants to merge 1 commit into
maxhully wants to merge 1 commit into
Conversation
…s in readGuestFileStream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
host/src/sandbox/server-ops.ts, there is avoid done.catch(() => {});line inside thereadGuestFileStreammethod. This prevents an unhandled rejection from crashing the whole process if the operation fails beforedoneis awaited. (For example, an abort can cause a rejection before we hitawait done.)This PR adds the same handling to
writeGuestFileanddeleteGuestFile, which have the same problem asreadGuestFileStreambut don't have the no-op handler to fix it.(I hit this unhandled rejection when aborting a task running in a Gondolin sandbox.)
Contribution Agreement
Please ensure this PR follows the guidelines in
CONTRIBUTING.md. (Author's note: uh... where?)By submitting this pull request, I confirm the following:
I understand that the entity Earendil Inc. (incorporated in the state of Delaware in 2025) needs some rights from me in order to utilize my contributions in this PR. As a contributor I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Earendil Inc. can use, modify, copy, and redistribute my contributions, under Earendil Inc.'s choice of terms.