Support wildcard subdomain keys for mapped TCP egress - #129
Draft
ShravanSunder wants to merge 1 commit into
Draft
Conversation
ShravanSunder
marked this pull request as draft
June 23, 2026 09:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds leading-label wildcard support for
tcp.hostsmapping keys, so callers can express dynamic subdomain fleets such as*.discord.gg:443without enumerating every regional host.The change keeps mapped TCP narrow:
UPSTREAM_HOST:UPSTREAM_PORT*TCP mappings remain rejectedapi.*.example.comremain rejected*.example.comdoes not match the apexexample.comCloses #128.
Tests
Passed locally:
Local environment note: this checkout did not have dependencies installed. I linked cached runtime packages to run the focused test. Attempts to run a clean package install/build locally were unreliable in this environment: one install attempt hit transient
ENOTFOUNDforregistry.npmjs.org, and later npm/pnpm install attempts hung. A repo-wide no-emit TypeScript check with partial dependencies failed on missing/partial dependency types outside this change (@types/node-forge,@types/ssh2,cbor2, undici/Node 26 type mismatch). The changedsrc/qemu/tcp.tsmodule passes a narrow no-emit TypeScript check.