feat(examples): add pi install support and update-safe config - #125
Open
ndimiduk wants to merge 1 commit into
Open
feat(examples): add pi install support and update-safe config#125ndimiduk wants to merge 1 commit into
ndimiduk wants to merge 1 commit into
Conversation
Ship `examples/pi-gondolin.ts` as a pi extension via `pi.extensions` in package.json, enabling `pi install npm:@earendil-works/gondolin`. HTTP hooks and secret injection are driven by update-safe config files (`~/.pi/agent/extensions/gondolin.json` and `<cwd>/.pi/gondolin.json`) instead of hardcoded values. With no config the VM runs with no outbound HTTP access. Config hardening: - Validate secret entry shape and hosts element types at load time - Skip secrets whose env var is not set (warn instead of injecting "") - Warn when project config overrides a global secret - Omit allowedHosts when empty so createHttpHooks defaults to allow-all rather than deny-all, which would block secrets-only configs - Guard user_bash against post-shutdown VM creation (leaked QEMU) - Exclude examples from tsconfig.build.json to keep dist/ clean Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is intended to improve the everyday usability of gondolin.
Ship
examples/pi-gondolin.tsas a pi extension viapi.extensionsin package.json, enablingpi install npm:@earendil-works/gondolin.HTTP hooks and secret injection are driven by update-safe config files (
~/.pi/agent/extensions/gondolin.jsonand<cwd>/.pi/gondolin.json) instead of hardcoded values. With no config the VM runs with no outbound HTTP access.Config hardening:
Provide a brief description of the changes in this PR here.
Contribution Agreement
Please ensure this PR follows the guidelines in
CONTRIBUTING.md.By submitting this pull request, I confirm the following:
I understand that the entity Earendil Inc. (incorporated in the state of Delaware in 2025) needs some rights from me in order to utilize my contributions in this PR. As a contributor I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Earendil Inc. can use, modify, copy, and redistribute my contributions, under Earendil Inc.'s choice of terms.