build: add extra property for docker image#335
Conversation
fixes eXist-db#334 Use new property `exist.docker.tag` to determine on which version to run the integration tests on.
| <image> | ||
| <alias>existdb-docs-tests</alias> | ||
| <name>existdb/existdb:${exist.processor.version}</name> | ||
| <name>existdb/existdb:${existdb.docker.tag}</name> |
There was a problem hiding this comment.
if we want to run tests on Mac against the minimum supported version I would still
| <name>existdb/existdb:${existdb.docker.tag}</name> | |
| <name>duncdrum/existdb:${existdb.docker.tag}</name> |
There was a problem hiding this comment.
@duncdrum I would not want to change the image this is tested on. As I wrote this only affects the release process on an arm machine. On CI however the tests will still be executed against all versions specified in the test matrix. As we will likely move the release to CI I don't see the benefit of testing on another base image.
There was a problem hiding this comment.
@line-o it affects all local build and test runs on macOS. What's the advantage of using an image we know won't run on macOS with the official min version?
There was a problem hiding this comment.
@duncdrum
a) this PR does not change the image being used to test
b) the ability to run the integration tests agains 6.1.0 on an arm Mac is still possible by running it on bare metal instead
There was a problem hiding this comment.
What bare metal. There is no Mac compatible image existdb/existdb:6.1.0 and since docker based integration tests are included in the build. You end up with a broken clone. Bare metal, in the cloud, or docker within docker
There was a problem hiding this comment.
I think this discussion is off-topic as the PR only attempts to decouple the test-instance version from the minimum required processor version.
|
obsolete after #367 was merged |
2 participants
Use new property
exist.docker.tagto determine on which version to run the integration tests on.I think it is imperative to decouple the minimum required processor version from the version / tag of the instance the code is being tested on.
fixes #334