java admin client enhancements#6372
Draft
duncdrum wants to merge 8 commits into
Draft
Conversation
Introduce ClientSwingEdt (invokeAndWaitIfNeeded / invokeLaterIfNeeded) and use it from ClientFrame for error dialogs, shell display, resource table updates, and status text. Migrate DocumentView save/save-as to SwingWorker and marshal ProgressObserver updates to the EDT. ClientAction is unchanged: non-GUI callers still handle failures on the calling thread (e.g. InteractiveClient console path). see #4355
Replace QueryRunnable/thread with QuerySwingWorker (publish to EDT). Convert remove, move, rename, copy, reindex, upload, and restore off newClientThread to SwingWorker; fix restore confirm and reload paths for EDT safety. see #4355
Add InteractiveClient.runOnFrameEdt and route setPath, setStatus, edit/get/show shell output, and error dispose through ClientSwingEdt.invokeAndWaitIfNeeded. Start ProcessRunnable on a named virtual thread instead of newClientThread. Closes #4355
Shell `edit` now uses ClientSwingXmlWorker so retrieve() runs in the worker thread and DocumentView is opened from SwingWorker.done() on the EDT. Extract ClientDocumentEditSupport for testable load-only I/O. Tests: ClientSwingEdtTest (exception propagation, invokeLater order); ClientDocumentEditSupportTest (XMLDBException propagation, payload). see #4355
Shell get: try-with-resources on EXistResource after retrieve. Add consoleErr/errorln overloads with optional Throwable; use in main, process(), more(), scheduleEditResource, trace writer, and passwd/adduser. Add setExistImage / setExistImageIcon and use across client dialogs. ClientFrame FileListDropTargetListener extends DropTargetAdapter. see #6046
duncdrum
added
enhancement
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Contributor
Author
|
Huh that's new |
Member
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry for the accidental push to upstream. Since I touched this stuff recently, I figured I d have a go at pushing this further. Not a heavy user of JAC, or swing framework. needs proper testing likely on windows as well
Have a look. Steals ideas from @reinhapa in #6046
close #4355