Set the correct media type for login response and parse the Accept header #801
Open
marmoure wants to merge 1 commit into
Open
Set the correct media type for login response and parse the Accept header #801marmoure wants to merge 1 commit into
marmoure wants to merge 1 commit into
Conversation
19914a1 to
bae133a
Compare
duncdrum
requested changes
May 21, 2026
Contributor
duncdrum
left a comment
There was a problem hiding this comment.
Thanks for the PR @marmoure. The Xqdoc is not well-formed.
We don't normally link elemental issues. Feel free to keep it in alongside an exist issue. But both should be properly formatted.
Please add a test. Did you test this against exist? Which version?
bae133a to
9fe078a
Compare
Contributor
Author
|
Thanks for the @duncdrum I fixed the xqdoc issue, this was tested on eXist-db 6.4.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds parsing for
Acceptheader and introduceslocal:accept-jsonandlocal:preferred-media-type, it build on top of #800 to fix #253.These functions allow more robust and future proof way for getting the appropriate header either the preferred one or a specific one.
Also when trying to set the correct headers for the login response using
I encountered a bug in the
RESTServerinwriteResultJSONwhich ignored theoutput:medita-typeoption, I added evolvedbinary/elemental#212 for elemental and the same should be done for eXist-db.In the mean time
is being used as workaround until this bug is resolved.