Skip to content

Fix ssc bus not updated by create_continuous_bus_index #3078 - #3109

Open
quinnbmccarthy wants to merge 1 commit into
e2nIEE:developfrom
quinnbmccarthy:fix-ssc-bus-continuous-reindex
Open

Fix ssc bus not updated by create_continuous_bus_index #3078#3109
quinnbmccarthy wants to merge 1 commit into
e2nIEE:developfrom
quinnbmccarthy:fix-ssc-bus-continuous-reindex

Conversation

@quinnbmccarthy

Copy link
Copy Markdown

Fixes #3078

ssc was missing from element_bus_tuples() in pandapower/toolbox/element_selection.py,
which is the central registry that create_continuous_bus_index (and other toolbox
functions) use to know which element tables have a bus column that needs updating on
reindex. As a result, an ssc's bus value went stale after reindexing while every other
bus-connected element updated correctly.

  • Added ("ssc", "bus") to element_bus_tuples()
  • Extended test_continuos_bus_numbering to include an ssc element, so the existing
    generic "all element bus references stay valid after reindex" assertion covers it
    (confirmed this test fails on develop without the fix, passes with it)
  • Added a changelog entry

@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Aug 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.10%. Comparing base (7b972fc) to head (66ebdc4).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3109   +/-   ##
========================================
  Coverage    72.10%   72.10%           
========================================
  Files          355      355           
  Lines        39398    39398           
========================================
  Hits         28408    28408           
  Misses       10990    10990           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ssc bus not updated from create_continuous_bus_index

1 participant