Fix ssc bus not updated by create_continuous_bus_index #3078 - #3109
Open
quinnbmccarthy wants to merge 1 commit into
Open
Fix ssc bus not updated by create_continuous_bus_index #3078#3109quinnbmccarthy wants to merge 1 commit into
quinnbmccarthy wants to merge 1 commit into
Conversation
|
6 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #3109 +/- ##
========================================
Coverage 72.10% 72.10%
========================================
Files 355 355
Lines 39398 39398
========================================
Hits 28408 28408
Misses 10990 10990 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #3078
sscwas missing fromelement_bus_tuples()inpandapower/toolbox/element_selection.py,which is the central registry that
create_continuous_bus_index(and other toolboxfunctions) use to know which element tables have a
buscolumn that needs updating onreindex. As a result, an ssc's
busvalue went stale after reindexing while every otherbus-connected element updated correctly.
("ssc", "bus")toelement_bus_tuples()test_continuos_bus_numberingto include ansscelement, so the existinggeneric "all element bus references stay valid after reindex" assertion covers it
(confirmed this test fails on develop without the fix, passes with it)