Add unitless solver tolerance option - #3070
Open
Ehsanpoly wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v4.0.0 #3070 +/- ##
===============================================
Coverage 75.03% 75.04%
===============================================
Files 357 357
Lines 39553 39558 +5
===============================================
+ Hits 29679 29685 +6
+ Misses 9874 9873 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Ehsanpoly
force-pushed
the
add-unitless-solver-tolerance
branch
from
July 12, 2026 20:30
dc2bdd8 to
fa14dc9
Compare
Contributor
|
@Ehsanpoly , thanks for the PR. I like your change, I'll discuss if we can somehow mark tolerance_mva as deprecated. But If I remember correctly this is not so easily be done. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2750.
This PR adds
solver_toleranceas a unitless power-flow solver tolerance option for pandapower 4.The existing
tolerance_mvaoption is kept as a backward-compatible alias, but the documentation is updated to clarify that the value is treated as a solver tolerance rather than an MVA quantity.No numerical solver behavior is changed in this PR.