Skip to content

docs: integrate deprecation guidelines into CONTRIBUTING.md - #3013

Open
william-xue wants to merge 8 commits into
e2nIEE:developfrom
william-xue:docs/integrate-deprecation-guidelines
Open

docs: integrate deprecation guidelines into CONTRIBUTING.md#3013
william-xue wants to merge 8 commits into
e2nIEE:developfrom
william-xue:docs/integrate-deprecation-guidelines

Conversation

@william-xue

Copy link
Copy Markdown

Summary

This PR integrates the deprecation guidelines from the existing documentation into CONTRIBUTING.md, as requested in #2974.

The new section covers:

  • When to use deprecation warnings (parameter changes, behavior changes, function moves)
  • The two-PR process (PR2 for interim code with warnings, PR1 for final removal)
  • How to implement warnings using warnings.warn
  • How to add version assertions to deprecated tests
  • Reviewer/merger responsibilities

A changelog entry has also been added.

Test plan

  • Review the new section in CONTRIBUTING.md for accuracy against the source documentation
  • Verify the link to the full deprecation guidelines documentation is correct

Closes #2974

Add a Deprecation Guidelines section to CONTRIBUTING.md summarizing
the two-PR deprecation process from doc/about/deprecating.rst, so
new contributors can find this information alongside other contributing
guidelines.

Closes e2nIEE#2974
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.12%. Comparing base (4f139fa) to head (0b460b5).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3013   +/-   ##
========================================
  Coverage    72.12%   72.12%           
========================================
  Files          355      355           
  Lines        39376    39376           
========================================
  Hits         28399    28399           
  Misses       10977    10977           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KS-HTK

KS-HTK commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Thank you for you're PR!

Just to let you know we have not forgotten it:
We wanted to take our time with this PR, as we would like to revise the deprecation guidelines while we are at it. So this PR may take a while before we finally merge it.

No action is required from you.

@vogt31337
vogt31337 marked this pull request as draft July 8, 2026 08:08
…eprecation-guidelines

# Conflicts:
#	CHANGELOG.rst
@william-xue
william-xue marked this pull request as ready for review July 13, 2026 02:33
…eprecation-guidelines

# Conflicts:
#	CHANGELOG.rst
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate deprecating guidelines into contributing.md

2 participants