Skip to content

Distribution in station controller - #2898

Draft
MMatthiessen wants to merge 79 commits into
e2nIEE:developfrom
MMatthiessen:distribution_in_station_controller
Draft

Distribution in station controller#2898
MMatthiessen wants to merge 79 commits into
e2nIEE:developfrom
MMatthiessen:distribution_in_station_controller

Conversation

@MMatthiessen

Copy link
Copy Markdown
Contributor
  • adding distributions in station controller
  • adding tests for distributions
  • adapting import function for importing distribution from Powerfactory
  • adapting convert_format for new station controller

… of the develop branch.

Ruggedizing the code for different inputs types and maintaining backwards compatibility.
… of the develop branch.

Ruggedizing the code for different inputs types and maintaining backwards compatibility.

Repairing the output_values_distribution functionality
…sion of the develop branch.

Ruggedizing the code for different inputs types and maintaining backwards compatibility.

Adding a testing functionality
…sion of the develop branch.

Ruggedizing the code for different inputs types and maintaining backwards compatibility.

- fixing some errors in spelling and functionality of votage droop
…sion of the develop branch.

Ruggedizing the code for different inputs types and maintaining backwards compatibility.

- fixing v_droop_ctrl and reordering pf import test
…sion of the develop branch.

Ruggedizing the code for different inputs types and maintaining backwards compatibility.

- removing deprecated attribute overwrite_convergence
# Conflicts:
#	pandapower/control/controller/station_control.py
#	pandapower/converter/powerfactory/pp_import_functions.py
#	pandapower/test/control/test_stactrl.py
…sion of the develop branch.

- merged develop
- ruggedized code for 1 output element
…sion of the develop branch.

- assured droop controller convergence, problems with v_droop
# Conflicts:
#	pandapower/control/controller/station_control.py
#	pandapower/test/control/test_stactrl.py
…it exists)

improving assertion logic for error info after failed convergence
…roller' into pushable_changes_of_station_controller
# Conflicts:
#	pandapower/control/controller/station_control.py
#	pandapower/converter/powerfactory/pp_import_functions.py
#	pandapower/test/control/test_stactrl.py
…ally for better readability

- first implementation
…ally for better readability

- changing testing environment to work with new methodology
…ally for better readability

- changing testing environment to work with new methodology
…ally for better readability

- changing testing environment to work with new methodology
…ally for better readability

- changing testing environment to work with new methodology
…ally for better readability

- Substituting voltage_ctrl for control_modus in droop_controller
- Assuring legacy support
- Adapting testing functionality
@vogt31337

Copy link
Copy Markdown
Contributor

@MMatthiessen the mandatory part of the pipeline failed. Could you update your PR? Or have a look into it?

@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@MMatthiessen

Copy link
Copy Markdown
Contributor Author

@HaoCao23, please have a look

@codecov

codecov Bot commented Apr 14, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.75410% with 172 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.94%. Comparing base (4917c0d) to head (96f6e4f).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
pandapower/control/controller/station_control.py 74.56% 103 Missing ⚠️
...ower/converter/powerfactory/pp_import_functions.py 1.42% 69 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2898      +/-   ##
===========================================
- Coverage    71.98%   71.94%   -0.04%     
===========================================
  Files          352      352              
  Lines        38591    38946     +355     
===========================================
+ Hits         27779    28019     +240     
- Misses       10812    10927     +115     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud

sonarqubecloud Bot commented May 6, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants