Feature/fixing transformer kt min case - #2739
Draft
vogt31337 wants to merge 11 commits into
Draft
Conversation
…f short-circuit calculations, Adapting tests
…_kt_min_case' into fix/trafo_k_t_values # Conflicts: # pandapower/build_branch.py
Fix/trafo k t values
…2nIEE/pandapower into feature/fixing_transformer_kt_min_case
Contributor
Author
|
fixed as far as I could, but for the min case there are the parameters missing. @envelio-cb could you have a look into this and maybe add the missing paramters? |
vogt31337
marked this pull request as draft
October 7, 2025 09:51
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2739 +/- ##
===========================================
+ Coverage 74.69% 74.90% +0.21%
===========================================
Files 294 315 +21
Lines 36026 36354 +328
===========================================
+ Hits 26909 27232 +323
- Misses 9117 9122 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
@envelio-cb , short reminder, that the PR still has issues. Can you fix them? |
Contributor
|
Can be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editable version of #2168