Harden JSON deserialization against arbitrary code execution - #818
Open
kbensafta wants to merge 2 commits into
Open
Harden JSON deserialization against arbitrary code execution#818kbensafta wants to merge 2 commits into
kbensafta wants to merge 2 commits into
Conversation
Collaborator
|
last stable release.
Contributor
Author
|
@SimonRubenDrauz I bumped pandapower from 3.3.3 to 3.5.4 which made the tests pass. But I just noticed that there is PR #817 that addresses the same problem, so I don't know which one we should keep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns pandapipes' JSON loading mechanism with the recent security patch in pandapower, Commit f105e70.
The rest() method in the deserialization registry now uses pandapower's _is_safe_to_deserialize helper to prevent the loading of arbitrary, non-pandapipes-related objects. This closes a remote code execution vulnerability.
Additionally, this commit exposes the skip_checks parameter in from_json and from_json_string to allow trusted files to bypass these new security checks, maintaining API consistency with pandapower.