Rename alpha_w_per_m2k to u_w_per_m2k - #720
Open
dad616610 wants to merge 11 commits into
Open
Conversation
EPrade
reviewed
Jun 30, 2025
EPrade
left a comment
Contributor
There was a problem hiding this comment.
Looks good, thank you! Could you also add a changelog entry?
Contributor
Author
|
Done! |
Contributor
|
Could you solve the merge conflicts please? Then we would merge the PR. Thanks! |
dad616610
force-pushed
the
rename_alpha_to_u
branch
from
July 16, 2025 18:01
fdda132 to
38031e1
Compare
Contributor
Author
|
Apologies for expanding the scope right before merge - I noticed the variable naming inconsistency during rebase and felt it was worth addressing now for consistency. I've rebased to resolve conflicts and:
Open questions:
|
Collaborator
|
Thanks for your contribution. Regarding your two questions see my answers below:
|
Contributor
Author
|
Done! I've renamed the network files as suggested. Please let me know if it looks good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes the renaming of the heat transfer coefficient parameter from
alpha_w_per_m2ktou_w_per_m2kto align with standard thermodynamic notation (U = overall heat transfer coefficient). The changes include:Key changes
Parameter updates
alpha_w_per_m2ktou_w_per_m2kthroughout codebaseDocumentation:
u_w_per_m2kand new descriptionTest Updates:
alpha_w_per_m2ksyntax to useu_w_per_m2k(modified test_heat_consumer.py)alpha_w_per_m2k(unchanged)