Stanet converter 2.0 - #618
Open
SimonRubenDrauz wants to merge 14 commits into
Open
Conversation
…rauz/pandapipes into stanet_converter_2.0
dlohmeier
reviewed
May 8, 2024
| **add_info | ||
| ) | ||
| max_mdot_kg_per_s=control_table.QSOLL.values[is_pc].astype(float) / 3600 * fluid.get_density(NORMAL_TEMPERATURE), | ||
| **add_info) |
Collaborator
There was a problem hiding this comment.
For this, we need #619 to be merged? Is max_mdot_kg_per_s then always required? Can we add the column to the press_control as it it implemented currently?
dlohmeier
reviewed
May 8, 2024
dlohmeier
left a comment
dlohmeier
left a comment
Collaborator
There was a problem hiding this comment.
In general, this all looks good to me and should add some clarification wrt. dtypes. Could you just check if the pressure control implementation works as intended?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.