Skip to content

Try xterm renderer addons for terminal#436

Merged
matthewlouisbrockman merged 1 commit into
mainfrom
xterm-tweaks
Jun 18, 2026
Merged

Try xterm renderer addons for terminal#436
matthewlouisbrockman merged 1 commit into
mainfrom
xterm-tweaks

Conversation

@matthewlouisbrockman

@matthewlouisbrockman matthewlouisbrockman commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

renderer addons make everything better
Screenshot 2026-06-17 at 7 33 03 PM

after:
Screenshot 2026-06-17 at 7 31 58 PM

@cursor

cursor Bot commented Jun 18, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Client-only terminal UX changes with graceful renderer fallback; no auth, API, or data-path changes.

Overview
Adds @xterm/addon-fit, @xterm/addon-webgl, and @xterm/addon-canvas and wires them into useTerminalInstance for sharper rendering and better container sizing.

FitAddon runs at the start of resizeTerminal() so the terminal tracks the panel before cols/rows are computed and propagated to the PTY. WebglAddon is loaded first for performance; on init failure or WebGL context loss it falls back to CanvasAddon, with subscriptions and addons disposed on teardown. Initial transcript restore and post-resize paths now scroll to bottom so the view stays anchored on the latest output.

Reviewed by Cursor Bugbot for commit f23cf53. Bugbot is set up for automated code reviews on this repo. Configure here.

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web Ready Ready Preview, Comment Jun 18, 2026 2:53am

Request Review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit dcc4c5a. Configure here.

Comment thread src/features/dashboard/terminal/use-terminal-instance.ts Outdated
Comment thread src/features/dashboard/terminal/use-terminal-instance.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dcc4c5acbc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/features/dashboard/terminal/use-terminal-instance.ts Outdated
@matthewlouisbrockman matthewlouisbrockman merged commit 58abb98 into main Jun 18, 2026
14 checks passed
@matthewlouisbrockman matthewlouisbrockman deleted the xterm-tweaks branch June 18, 2026 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants