Skip to content

refactor(forum): drop four dead locals and initialise $tracktext #5876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deltik merged 1 commit into from
Aug 5, 2026
+2 −4
Merged

refactor(forum): drop four dead locals and initialise $tracktext #5876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion e107_plugins/forum/forum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,9 +415,10 @@ function forum_track()
$tp = e107::getParser();

$trackDiz = ($trackEmailPref) ? LAN_FORUM_3040 : LAN_FORUM_3041;
$tracktext = '';


if($trackedThreadList = $forum->getTrackedThreadList(USERID, 'list'))
if($forum->getTrackedThreadList(USERID, 'list'))
{

$viewed = $forum->threadGetUserViewed();
Expand Down
2 changes: 0 additions & 2 deletions e107_plugins/forum/forum_class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ public function __construct($update= false)
}

$this->e107 = e107::getInstance();
$tp = e107::getParser();
$this->userViewed = array();
$this->modArray = array();

Expand Down Expand Up @@ -1138,7 +1137,6 @@ function threadViewed($threadId)

function getTrackedThreadList($id, $retType = 'array')
{
$e107 = e107::getInstance();
$sql = e107::getDb();

$id = (int)$id;
Expand Down
1 change: 0 additions & 1 deletion e107_plugins/forum/shortcodes/batch/view_shortcodes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,7 +1070,6 @@ function sc_nextprev()
function sc_track()
{

global $forum;
if(!empty($this->pref['track']) && USER)
{
// BC Fix for old template.
Expand Down
Loading