Skip to content

fix(forum): close the authorisation holes, and give the plugin its first tests (v2.3.x) #5862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Deltik merged 13 commits into from
Aug 1, 2026
Merged

fix(forum): close the authorisation holes, and give the plugin its first tests (v2.3.x) #5862

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
910094a
fix(tests): create every table a plugin ships, with the engine e107 w…
e107help Aug 1, 2026
5420740
test(forum): give the suite a forum it can actually test against
e107help Aug 1, 2026
0a2412d
fix(forum): confine moderation to the forum it was granted in
e107help Aug 1, 2026
ff69515
fix(forum): make "your own post" mean your own post
e107help Aug 1, 2026
e4f87c7
fix(forum): stop a post deletion reaching outside its own attachment …
e107help Aug 1, 2026
08b5f11
fix(forum): tie a quick reply and a subscription to the thread they name
e107help Aug 1, 2026
774fe46
fix(forum): make the new-threads listing answer to the caller's permi…
e107help Aug 1, 2026
c9ae284
fix(forum): make the ajax answer match what actually happened
e107help Aug 1, 2026
7e82a1b
fix(forum): keep the forum's own bookkeeping honest
e107help Aug 1, 2026
2e6c1e6
fix(forum): render the new-topics listing with a thread template
e107help Aug 1, 2026
bdd2723
fix(forum): make the click handlers do what the click asked for
e107help Aug 1, 2026
dd18b46
fix(forum): stop the report form being a way to send mail on demand
e107help Aug 1, 2026
ab10520
fix(tests): port the forum fixes to this line's database and test APIs
e107help Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions e107_plugins/forum/forum.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,19 @@ public function init($forum)
$FORUM_MAIN_PARENT = $FORUM_TEMPLATE['main']['parent_start'];
}

$FORUM_NEWPOSTS_START = $FORUM_TEMPLATE['main']['start']; // $FORUM_TEMPLATE['new-start'];
$FORUM_NEWPOSTS_MAIN = $FORUM_TEMPLATE['main']['forum']; // $FORUM_TEMPLATE['new-main'];
$FORUM_NEWPOSTS_END = $FORUM_TEMPLATE['main']['end']; // $FORUM_TEMPLATE['new-end'];
// The rows in the new-topics listing are threads, so they need the
// thread template. This used to reach for the forum row template,
// whose shortcodes resolve against a forum and against nothing on a
// thread, so forum.php?new rendered an empty table under a v2 theme.
//
// Fetched with merge on and keyed to the section, so a theme that
// predates it falls back to the plugin's, and one that overrides
// only part of it keeps the rest.
$FORUM_NEWPOSTS = e107::getTemplate('forum', 'forum', 'newposts', true, true);

$FORUM_NEWPOSTS_START = varset($FORUM_NEWPOSTS['start'], $FORUM_TEMPLATE['main']['start']);
$FORUM_NEWPOSTS_MAIN = varset($FORUM_NEWPOSTS['item'], $FORUM_TEMPLATE['main']['forum']);
$FORUM_NEWPOSTS_END = varset($FORUM_NEWPOSTS['end'], $FORUM_TEMPLATE['main']['end']);
}

require_once(HEADERF);
Expand Down
Loading
Loading