Uniform usage of print or _print() helper#582
Merged
Conversation
As a zsh script the builtin print should be used instead of echo. And mostly done that way. Therefore replace the few echo calls with print. And additionally replace cat construct for printing the system utils. This part would even appear if "tomb --version -q" would be called (nonsensical in a way). With this only the empty print will cause newlines. But cannot be replaced as the current wrapper _print doesn't allow empty input. And those cat thingies always look ugly and it offers no real benefit in that location.
Member
|
Very nice cleanup! also print is a built-in so this speeds up things a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a zsh script the builtin print should be used instead of echo. And mostly done that way. Therefore replace the few echo calls with print.
And additionally replace cat construct for printing the system utils. This part would even appear if "tomb --version -q" would be called (nonsensical in a way). With this only the empty print will cause newlines. But cannot be replaced as the current wrapper _print doesn't allow empty input.
And those cat thingies always look ugly and it offers no real benefit in that location.