Add option --pinentry#580
Merged
Merged
Conversation
This allows to specify a specifc pinentry program which is tried first while finding a working pinentry program. For input is only the part needed after "pinentry-". This isn't a general option to specify something completly different as password input (yet). The update to the manpage includes the new option and an update to the pinentry section. With the way how pinentry is nowadays detected, the manual force of a specific pinentry via symlink shouldn't be encouraged. And if a specific one should be used, one can use now the new option.
Member
|
Oh this is very good for now, should have been there since the beginning: always provide a way to select manually the options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows to specify a specific pinentry program which is tried first while finding a working pinentry program.
For input is only the part needed after "pinentry-". This isn't a general option to specify something completly different as password input (yet).
The update to the manpage includes the new option and an update to the pinentry section. With the way how pinentry is nowadays detected, the manual force of a specific pinentry via symlink shouldn't be encouraged. And if a specific one should be used, one can use now the new option.
Doesn't really help with the big ToDos in
ask_password(), but allows in theory the usage of pinentries likewaypromptorpinentry-bemenu.Did take a look into adding the wrapper.. but this is not a small change. Especially with all the possible corner cases.
And with the ToDo in regards to use
read -s -ras a fallback... this needs some more thinking.