feat: extend extensions — install from Hub/zip, schema inspection, Ac…#158
Conversation
…tiveGate groups - add `dtctl create extension` with --hub-extension and -f (zip upload) flags - add --monitoring-configuration-schema, --no-fluff, --active-gate-groups to describe extension - add extensions:definitions:write scope to all write-capable safety levels - add unit, integration, and golden tests for all new functionality
Code reviewFound 3 issues:
dtctl/cmd/describe_extensions.go Lines 165 to 168 in 0c7029f
dtctl/docs/dev/IMPLEMENTATION_STATUS.md Lines 76 to 79 in 0c7029f
dtctl/cmd/create_extensions.go Lines 86 to 91 in 0c7029f dtctl/cmd/create_extensions.go Lines 111 to 115 in 0c7029f |
Signed-off-by: MaciejGrynda <85988949+MaciejGrynda@users.noreply.github.com>
- Return an explicit error when --version is passed with --file, instead
of silently ignoring the flag as documented ("only for --hub-extension").
- When InstallFromHub returns 409 without a version specified, report
"(latest version) is already installed" instead of version "".
- Add unit test coverage for the new validation and error branch.
discostu105
left a comment
There was a problem hiding this comment.
Reviewed and tested locally — all tests pass, build and vet clean. Code looks solid: good flag validation, thorough error handling, comprehensive test coverage including golden tests. A few minor observations (non-blocking): StripSchemaFluff mutates the input map in-place, no file size guard on zip upload, and the ActiveGateEntry.Errors unmarshal error is silently swallowed in the table formatter. None of these are blockers. LGTM.
feat: extend extensions — install from Hub/zip, schema inspection, ActiveGate groups
dtctl create extensionwith --hub-extension and -f (zip upload) flagsDescription
Related Issues
Closes #143
Testing
make test)make lint)