Conversation
… from Open Dylan formula
Adds the two standard Homebrew tap workflows: - tests.yml: runs brew test-bot on push to master and PRs - publish.yml: publishes bottles when a PR is labeled pr-pull Closes dylan-lang#10
There was a problem hiding this comment.
Pull request overview
This PR updates the Open Dylan Homebrew formula to version 2026.1.0 and adds CI testing via GitHub Actions. The changes simplify the formula structure by removing the explicit stable block and modernizing the API usage, while adding automated testing infrastructure.
Changes:
- Updated Open Dylan to version 2026.1.0 and simplified formula structure
- Modernized Homebrew API usage (verbose? instead of ARGV.verbose?)
- Added GitHub Actions CI workflow with brew test-bot on macOS 13 and 15
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| opendylan.rb | Updated to v2026.1.0, removed stable block, simplified dependencies, modernized API calls, removed Intel-only architecture constraint |
| .github/workflows/tests.yml | New CI workflow using brew test-bot to test formula on Intel and ARM macOS runners |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| homepage "https://opendylan.org/" | ||
| url "https://github.com/dylan-lang/opendylan/releases/download/v2026.1.0/opendylan-2026.1-x86_64-darwin.tar.bz2" | ||
| sha256 "305bcba52914713508fa1a97b5b6d7e042fba1b0d1415eab90c35417b2da15cd" | ||
|
|
There was a problem hiding this comment.
The arch: :intel constraint was removed, but the stable release URL still points to an x86_64-darwin binary at line 8. This creates an inconsistency - the formula will now allow installation on Apple Silicon (ARM) Macs, but the binary is Intel-only. Either the arch constraint should be kept, or ARM binaries should be added using a conditional URL based on Hardware::CPU architecture.
| depends_on arch: :intel |
There was a problem hiding this comment.
@copilot code review[agent] Don't other formulas do this and warn the user Rosetta is needed?
| test: | ||
| strategy: | ||
| matrix: | ||
| os: [macos-13, macos-15] |
There was a problem hiding this comment.
The CI workflow tests on both macos-13 (Intel) and macos-15 (Apple Silicon), but the formula only provides an x86_64-darwin binary without the architecture constraint that was previously in place. This will likely cause test failures on macos-15 since ARM Macs cannot run the Intel-only binary without Rosetta configuration. Consider either adding the arch constraint back to the formula, providing ARM binaries, or adjusting the CI matrix to only test on Intel runners for now.
| os: [macos-13, macos-15] | |
| os: [macos-13] |
| - name: Set up Homebrew | ||
| id: set-up-homebrew | ||
| uses: Homebrew/actions/setup-homebrew@master | ||
|
|
There was a problem hiding this comment.
The workflow is missing a checkout step to retrieve the repository code. The brew test-bot commands need access to the formula files in this repository, but there's no actions/checkout step before running the tests. Add a checkout step after the Homebrew setup to ensure the formulae are available for testing.
| - name: Check out repository | |
| uses: actions/checkout@v4 |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
See if the CI works.