Skip to content

fix: improve dark mode text contrast in mobile nav#3591

Open
roopamdeep wants to merge 2 commits intodubinc:mainfrom
roopamdeep:fix/brand-mobile-nav-contrast
Open

fix: improve dark mode text contrast in mobile nav#3591
roopamdeep wants to merge 2 commits intodubinc:mainfrom
roopamdeep:fix/brand-mobile-nav-contrast

Conversation

@roopamdeep
Copy link
Copy Markdown

@roopamdeep roopamdeep commented Mar 16, 2026

Problem

Navigation menu items appear dim/low contrast
on /brand page in dark mode on mobile.

Root Cause

Text color was set to dark:text-white/70 (70% opacity)
causing low contrast against dark background.

Fix

Changed dark:text-white/70 to dark:text-white
for full opacity text in dark mode.

Fixes #3551

Summary by CodeRabbit

  • Style
    • Refined dark mode styling in mobile navigation for improved visual clarity. Enhanced contrast and brightness of navigation menu icons and container elements, providing better readability and visual experience for users in dark mode.

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 16, 2026

@roopamdeep is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 16, 2026

CLA assistant check
All committers have signed the CLA.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 29e0c4da-4ae7-4243-849a-d72e1e15a350

📥 Commits

Reviewing files that changed from the base of the PR and between b81b3b3 and e2d4516.

📒 Files selected for processing (1)
  • packages/ui/src/nav/nav-mobile.tsx

📝 Walkthrough

Walkthrough

Fixed dark mode contrast in mobile navigation by increasing text opacity from 70% to 100% for the menu icon, close button, and navigation container, directly addressing readability issues on dark backgrounds.

Changes

Cohort / File(s) Summary
Mobile Navigation Dark Mode Styling
packages/ui/src/nav/nav-mobile.tsx
Updated dark mode text opacity from dark:text-white/70 to dark:text-white for the Menu icon, X close button, and mobile nav container to improve contrast and readability.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested reviewers

  • steven-tey

Poem

🐰 hop hop Through dark mode we bound,
Where nav items now stand out, crystal clear and found!
From seventy to full white—contrast wins the day,
Mobile menus bright and readable, hip-hip-hooray! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: improving dark mode text contrast in the mobile navigation component through opacity adjustments.
Linked Issues check ✅ Passed The code changes directly address issue #3551 by increasing text contrast in the mobile navigation dark mode from dark:text-white/70 to dark:text-white.
Out of Scope Changes check ✅ Passed All changes are scoped to the mobile navigation dark mode contrast improvement; no unrelated modifications are present.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can get early access to new features in CodeRabbit.

Enable the early_access setting to enable early access features such as new models, tools, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Mobile dark mode issue: Navigation menu items have low contrast on /brand page

2 participants