fix: improve dark mode text contrast in mobile nav#3591
fix: improve dark mode text contrast in mobile nav#3591roopamdeep wants to merge 2 commits intodubinc:mainfrom
Conversation
|
@roopamdeep is attempting to deploy a commit to the Dub Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughFixed dark mode contrast in mobile navigation by increasing text opacity from 70% to 100% for the menu icon, close button, and navigation container, directly addressing readability issues on dark backgrounds. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can get early access to new features in CodeRabbit.Enable the |
Problem
Navigation menu items appear dim/low contrast
on /brand page in dark mode on mobile.
Root Cause
Text color was set to
dark:text-white/70(70% opacity)causing low contrast against dark background.
Fix
Changed
dark:text-white/70todark:text-whitefor full opacity text in dark mode.
Fixes #3551
Summary by CodeRabbit