docs(skill): record jvmmodel-batch learnings in xtend-to-java - #1540
Draft
joaodinissf wants to merge 1 commit into
Draft
joaodinissf wants to merge 1 commit into
joaodinissf wants to merge 1 commit into
Conversation
Learned migrating the ten jvmmodel files (expression, export, scope): 1. Tier 4 stays on the reference StringConcatenation chain when it has newLineIfNotEmpty after a dynamic value, two-arg append of a possibly multi-line value, or appendImmediate; append(null) appends nothing, so .formatted() interpolations of nullable values wrap in Strings.emptyIfNull. 2. JvmTypeReferenceBuilder.typeRef is provably non-null; to* builders with a nullable name stay guarded. 3. Dispatcher case order comes from xtend-gen, not source order; an unreachable terminal throw may be dropped. 4. Checkstyle JavadocMethod vs rule 1: complete missing @PARAM tags from a sibling overload; move dispatch Javadoc off the Void overload. 5. xbase.lib types stay in public signatures and callee-demanded callbacks. 6. BooleanExpressionComplexity vs SimplifyBooleanReturns: guard clauses or a named local, never a suppression. 7. PMD StringToString deviations are sanctioned and behaviour-neutral. 8. Gate commands need -pl :ddk-target; delete xtend-gen/com before the first compile; diff -r -x '.*' for the freshness check. 9. Tycho baseline bump: separate build: commit; features/category only when they also equal the baseline; sources artifact is compared. 10. .project Xtext builder/nature belong to the grammar; leave them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records in the
xtend-to-javaskill what the final jvmmodel batch (#1536) taught, so the skill matches how the last three migrations were actually adjudicated. Documentation only; no code.StringConcatenationchain when they carrynewLineIfNotEmpty()after a dynamic value, a two-argument indented append of a possibly multi-line value, orappendImmediate;append(null)appends nothing, so.formatted()interpolations of nullable values wrap inStrings.emptyIfNull.JvmTypeReferenceBuilder.typeRefis provably non-null;to*builders with a nullable name stay guarded.xtend-gen, never from source order.JavadocMethodvs "never invent Javadoc": complete the missing tag from a sibling overload.xbase.libtypes stay in public signatures and callee-demanded callbacks.BooleanExpressionComplexityvsSimplifyBooleanReturns: guard clauses or a named local, no suppression.StringToStringdeviations are sanctioned.-pl :ddk-target,…; delete the stalextend-gentwin before the first compile;diff -r -x '.*'for the freshness check..projectXtext builder/nature belong to the grammar and stay.🤖 Generated with Claude Code