Repository navigation
feat(sandboxer): passing Mount info across sandboxer and runtime - #154
Merged
Merged
Conversation
…tainerizedEngine`
dungdm93
force-pushed
the
mount-passing
branch
5 times, most recently
from
September 17, 2026 08:23
137c0bf to
41b3e2b
Compare
dungdm93
force-pushed
the
mount-passing
branch
2 times, most recently
from
September 17, 2026 09:35
b3216e6 to
f333b5c
Compare
Mount info across sandboxer and runtime
dungdm93
force-pushed
the
mount-passing
branch
3 times, most recently
from
September 17, 2026 10:42
22e76dc to
fba1c01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Introduces a unified
sandboxer.Mounterinterface to decouple mount topology decisions from sandbox engines and container runtimes. Sandboxers dictate how their directories are exposed (coarse vs discrete subpaths, bind vs volume mounts, runtime symlink resolution), while overlay engines and action runtimes consume mounts without engine-specific coupling.High-Level Design
sandboxer.MounterInterface:OverlayMounts(target Layout, coarse bool) []*types.Mount: Generates mounts for overlay JobContainers. Supports coarse mounts (whole job directory) when source and target layouts align, or discrete subpath mounts (workspace,temp,actions,tools,runtimes).RuntimeMounts(target Layout) []*types.Mount: Supplies mounts required by action containers (workspace,temp).LaunchResponse.Mounter.Sandboxer Implementations:
BindOptions: { Recursive: "enabled" }).runtimesto canonical host paths withReadOnly: trueso container runtimes access valid directories.type mounter string), generating named volume mounts with subpaths.Overlay & Runtime Integration:
containerizedEngine: Consumesresp.Mounter.OverlayMountswhen launching overlay JobContainers.wire_runtime: Injectssandboxer.Mountervia Dig. When running sibling action containers alongside a JobContainer, translates requested mounts through the parent JobContainer's mount namespace (translateContainerMounts). Directly applies mounts for direct sandboxes.