Repository navigation
sandboxer: refactor Layout from struct to interface - #153
Merged
Merged
Conversation
Layout from struct to interface
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Replace
sandboxer.Layoutfrom a plain struct with fields to a Go interface with methods. This decouples consumers from any specific layout implementation and makes it straightforward to supply custom layouts (e.g. in tests or future sandbox backends).Design
Before:
Layoutwas a struct with public string fields (Workspace,Temp,Actions,Tools,Runtimes). All sandboxes returned*Layout.After:
Layoutis an interface exposing those five paths as methods. A concreteStandardLayout(base string)type implements it by joining the base directory with each well-known subdirectory name. Sandboxes returnLayout(interface value).container.DefaultLayoutbecomes a package-levelStandardLayoutvalue rather than a factory function, eliminating theDefaultLayout("")call pattern.Changes
sandboxer/sandbox.go— defineLayoutinterface andStandardLayoutconcrete typehost,incus,containersandbox implementations — adoptStandardLayout, returnLayoutinterfaceexecutor,command,runtime,wire) — update to call interface methodsmock/sandboxer/sandbox.go— regenerated; addsMockLayoutfor test useMockLayout(custom paths) orStandardLayout(derived paths) instead of struct literals