Add E2E test for global.json paths-driven SDK install directory#53897
Draft
Copilot wants to merge 2 commits intorelease/dnupfrom
Draft
Add E2E test for global.json paths-driven SDK install directory#53897Copilot wants to merge 2 commits intorelease/dnupfrom
paths-driven SDK install directory#53897Copilot wants to merge 2 commits intorelease/dnupfrom
Conversation
Agent-Logs-Url: https://github.com/dotnet/sdk/sessions/20dc8a71-2232-4ec2-922d-d455418757c7 Co-authored-by: nagilson <23152278+nagilson@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add install logic for global.json parsing
Add E2E test for global.json Apr 15, 2026
paths-driven SDK install directory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing
InstallViaGlobalJson_SdkUsesGlobalJsonSourceE2E test only coveredversion/rollForwardinglobal.json— there was no test verifying that thepathsfield actually directs dotnetup to install the SDK into the specified local directory.Changes
InstallViaGlobalJson_PathsDirectsSdkToLocalDirectoryinLifecycleEndToEndTests:global.jsonwith"paths": [".dotnet"],"version": "9.0.103", and"rollForward": "disable"dotnetup sdk installwithout--install-path, exercising theInstallPathResolverpath that falls through toGlobalJsonInfo.SdkPath<project-dir>/.dotnet/sdk/9.0.103/paths-resolved directory withInstallSource.GlobalJsonand the correctGlobalJsonPath{ "sdk": { "version": "9.0.103", "rollForward": "disable", "paths": [".dotnet"] } }The implementation under test (
GlobalJsonInfo.SdkPath,InstallPathResolver.Resolve) was already in place; this test closes the coverage gap.