JIT: fold trivial redundant comparisons on loop induction variables#130205
Open
EgorBo wants to merge 2 commits into
Open
JIT: fold trivial redundant comparisons on loop induction variables#130205EgorBo wants to merge 2 commits into
EgorBo wants to merge 2 commits into
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts assertion propagation’s SSA-based range query budget so that RangeCheck::TryGetRange can successfully compute ranges for common loop induction-variable patterns, enabling folding of trivially redundant comparisons.
Changes:
- Increase the default SSA walk budget used by
assertionprop’s slowGetRangepath from 64 to 256. - Add an explanatory comment describing why
TryGetRangeneeds a larger shared budget due to multiple internal SSA walks.
Member
Author
|
@MihuBot -nuget |
This was referenced Jul 5, 2026
Open
f3f6bfd to
a45588c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #130206
G_M24707_IG02: xor ebx, ebx mov rsi, 0x... ; 'Hi' - jmp SHORT G_M24707_IG05 -G_M24707_IG03: - inc ebx -G_M24707_IG04: - test ebx, ebx - jl SHORT G_M24707_IG03 -G_M24707_IG05: +G_M24707_IG03: mov rcx, rsi call [System.Console:WriteLine(System.String)] inc ebx cmp ebx, 100 - jl SHORT G_M24707_IG04 + jl SHORT G_M24707_IG03Some nice diffs, mostly in tests, though.