Do not overwrite GetCopyToOutputDirectoryItemsDependsOn, just add new…#13474
Open
snechaev wants to merge 1 commit intodotnet:mainfrom
Open
Do not overwrite GetCopyToOutputDirectoryItemsDependsOn, just add new…#13474snechaev wants to merge 1 commit intodotnet:mainfrom
snechaev wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes MSBuild extensibility for GetCopyToOutputDirectoryItemsDependsOn by preserving any pre-existing (user- or import-provided) value instead of overwriting it in Microsoft.Common.CurrentVersion.targets, aligning it with the established “append-to-DependsOn property” pattern used elsewhere in the file.
Changes:
- Prepend
$(GetCopyToOutputDirectoryItemsDependsOn);to the default dependency list so customizations aren’t lost. - Enables users to insert custom targets at a specific stage of
GetCopyToOutputDirectoryItemsexecution (per #13471).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… values.
Fixes #13471
Context
The value of the
GetCopyToOutputDirectoryItemsDependsOnparameter was being overwritten, which made it difficult to add custom targets at a specific build stage.Changes Made
Overwrite the whole value was replaced by adding the new items to the existing value.
Testing
Notes