Skip to content

Performance optimizations for EscapingUtilities #13426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DustinCampbell wants to merge 22 commits into
base: main
Choose a base branch
from
Open

Performance optimizations for EscapingUtilities #13426

Show file tree
Hide file tree
Changes from 13 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
de94291
Clean up EscapingUtilities_Tests
DustinCampbell Mar 16, 2026
fac5a67
Add benchmarks for EscapingUtilities
DustinCampbell Mar 16, 2026
8a07ffd
Add BufferScope<T> to manage stack and ArrayPool<T> buffers
DustinCampbell Mar 16, 2026
58dff16
Add RefArrayBuilder<T> for building arrays cheaply
DustinCampbell Mar 16, 2026
85d6a22
Clean up EscapingUtilities in preparation for performance work
DustinCampbell Mar 19, 2026
73f2150
Add more test coverage to EscapingUtilities_Tests
DustinCampbell Mar 19, 2026
e610f87
EscapingUtilities.UnescapeAll should acquire StringBuilder lazily
DustinCampbell Mar 19, 2026
6bf3db4
Use SearchValues<char> to accelerate Escape on .NET
DustinCampbell Mar 19, 2026
bde1bff
Replace IndexOfAny with bitmask scan for Escape on .NET Framework
DustinCampbell Mar 19, 2026
43b2920
Reuse first IndexOfAnyEscapeChar result in Escape
DustinCampbell Mar 19, 2026
352057b
Refactor Escape to use two-pass direct string allocation
DustinCampbell Mar 19, 2026
6197fca
Scope IndexOf('%') in UnescapeAll to the active trim window
DustinCampbell Mar 20, 2026
2ff888d
Replace TryDecodeHexDigit arithmetic with HexConverter lookup table
DustinCampbell Mar 20, 2026
5402b1f
Fix bug in RefArrayBuilder<T>.Insert(...)
DustinCampbell Mar 30, 2026
39929a1
Merge branch 'main' into escapingutilities-perf
DustinCampbell Mar 31, 2026
e7222d5
Merge branch 'main' into escapingutilities-perf
DustinCampbell Apr 1, 2026
3f580df
Add string resources for RefArrayBuilder
DustinCampbell Apr 1, 2026
9ba9649
Merge branch 'main' into escapingutilities-perf
DustinCampbell Apr 7, 2026
dc7edc4
Merge branch 'main' into escapingutilities-perf
DustinCampbell Apr 8, 2026
b336ca0
Merge branch 'main' into escapingutilities-perf
DustinCampbell Apr 8, 2026
606494c
Merge branch 'main' into escapingutilities-perf
DustinCampbell Apr 9, 2026
4a463ab
Merge branch 'main' into escapingutilities-perf
DustinCampbell Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Build/BackEnd/TaskExecutionHost/TaskExecutionHost.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ public bool InitializeForBatch(TaskLoggingContext loggingContext, ItemBucket bat

TaskInstance.BuildEngine = _buildEngine;
TaskInstance.HostObject = _taskHost;

if (TaskInstance is IMultiThreadableTask multiThreadableTask)
{
multiThreadableTask.TaskEnvironment = TaskEnvironment;
Expand Down Expand Up @@ -1488,7 +1488,7 @@ private void GatherTaskItemOutputs(bool outputTargetIsItem, string outputTargetN
ProjectItemInstance newItem;

TaskItem outputAsProjectItem = output as TaskItem;
string parameterLocationEscaped = EscapingUtilities.EscapeWithCaching(parameterLocation.File);
string parameterLocationEscaped = EscapingUtilities.Escape(parameterLocation.File, cache: true);

if (outputAsProjectItem != null)
{
Expand Down
Loading
Loading