Skip to content

fix: handle wildcard '*' in --context parameter for UpdateDatabase an… #38269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrunoSync wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: handle wildcard '*' in --context parameter for UpdateDatabase an… #38269

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0a1d0ac
fix: handle wildcard '*' in --context parameter for UpdateDatabase an…
May 13, 2026
d765a84
fix: throw when no contexts found with wildcard, add test
May 14, 2026
e5c92fc
fix: handle wildcard '*' in --context parameter for UpdateDatabase
May 15, 2026
4803e2d
Throw OperationException when wildcard '*' is used with unsupported c…
May 15, 2026
66366b4
Extract migration logic into MigrateContext to avoid duplication
May 15, 2026
fa569a1
remove comment
May 15, 2026
79ed2a9
Add wildcard check to MigrationsBundleCommand
May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions src/EFCore.Design/Design/Internal/MigrationsOperations.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,29 @@ public virtual void UpdateDatabase(
string? connectionString,
string? contextType)
{
// Fix wildcard * issue #38254
Comment thread
AndriySvyryd marked this conversation as resolved.
Outdated
if (contextType == "*")
{
var contexts = _contextOperations.CreateAllContexts();
foreach (var item in contexts)
Comment thread
BrunoSync marked this conversation as resolved.
Outdated
{
using (item)
{
if (connectionString is not null)
item.Database.SetConnectionString(connectionString);
Comment thread
BrunoSync marked this conversation as resolved.
Outdated

var services = _servicesBuilder.Build(item);
EnsureServices(services);

var migrator = services.GetRequiredService<IMigrator>();
migrator.Migrate(targetMigration);
}
}
Comment thread
AndriySvyryd marked this conversation as resolved.

_reporter.WriteInformation(DesignStrings.Done);
return;
}

using (var context = _contextOperations.CreateContext(contextType))
{
if (connectionString != null)
Expand Down
17 changes: 17 additions & 0 deletions test/EFCore.Design.Tests/Design/Internal/MigrationsOperationsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,23 @@ public void AddMigration_throws_when_name_is_whitespace()
Assert.Equal(DesignStrings.MigrationNameRequired, exception.Message);
}

[ConditionalFact]
public void UpdateDatabase_with_wildcard_context_runs_for_all_contexts()
{
var assembly = MockAssembly.Create([typeof(AssemblyTestContext), typeof(TestContext)]);
Comment thread
BrunoSync marked this conversation as resolved.
Outdated
var operations = new TestMigrationsOperations(
new TestOperationReporter(),
assembly,
assembly,
"projectDir",
"RootNamespace",
"C#",
nullable: false,
args: []);

operations.UpdateDatabase(null, null, "*");
}

private class TestContext : DbContext;

private class AssemblyTestContext : DbContext
Expand Down