Skip to content

Cleanup: git config, implicit usings, test common fixes, and build props #4301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulmedynski merged 1 commit into from
May 29, 2026
+43 −344

Cleanup: git config, implicit usings, test common fixes, and build props

3018a56
Select commit
Loading
Failed to load commit list.
Merged

Cleanup: git config, implicit usings, test common fixes, and build props #4301

Cleanup: git config, implicit usings, test common fixes, and build props
3018a56
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Package succeeded May 21, 2026 in 37m 40s

Build #14109 had test failures

80 errors / 84 warnings

Details

Tests

  • Failed: 6 (0.00%)
  • Passed: 190,332 (96.60%)
  • Other: 6,685 (3.39%)
  • Total: 197,023

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 675 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

build.proj#L675 

build.proj(675,5): Error MSB3073: The command " "dotnet" test "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --collect "Code coverage" --settings "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/CodeCoverage.runsettings" --filter "category!=failing&category!=flaky&category!=interactive&category!=signed" -f net8.0 -p:TestSet="3" --results-directory "TestResults" --logger:"trx;LogFilePrefix=SqlClientManual-Windows_NT-net8.0-3" -p:ReferenceType=Package -p:AbstractionsPackageVersion=1.1.0-preview1ci14109 -p:LoggingPackageVersion=1.1.0-preview1ci14109 -p:SqlClientPackageVersion=7.1.0-preview1ci14109 -p:SqlServerPackageVersion=1.1.0-preview1ci14109 " exited with code 1.

Check failure on line 230 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L230 

Error: The process 'C:\hostedtoolcache\windows\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 233 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L233 

Dotnet command failed with non-zero exit code on the following projects : [ 'D:\\a\\_work\\1\\s\\build.proj' ]

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_NoCloses(commandType: Text)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_NoCloses(commandType: Text) 

Assert.Equal() Failure: Values differ
Expected: 6
Actual:   5
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.AssertSessionsAndRequests(SqlConnection connection, Int32 openMarsSessions, Int32 openRequests) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\MARSSessionPoolingTest\MarsSessionPoolingTest.cs:line 368
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_NoCloses(CommandType commandType) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\MARSSessionPoolingTest\MarsSessionPoolingTest.cs:line 312
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(commandType: Text)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(commandType: Text) 

Assert.Equal() Failure: Values differ
Expected: 3
Actual:   2
Raw output 
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.AssertSessionsAndRequests(SqlConnection connection, Int32 openMarsSessions, Int32 openRequests) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\MARSSessionPoolingTest\MarsSessionPoolingTest.cs:line 368
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(CommandType commandType) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\MARSSessionPoolingTest\MarsSessionPoolingTest.cs:line 226
   at InvokeStub_MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ParameterInOutAndReturn

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ParameterInOutAndReturn 

Microsoft.Data.SqlClient.SqlException : There is already an object named 'TestInAndOutParams' in the database.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ExecuteNonQueryCommand(String command) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\Batch\BatchTests.cs:line 667
   at Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ParameterInOutAndReturn() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\Batch\BatchTests.cs:line 401
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ParameterInOutAndReturn

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ParameterInOutAndReturn 

Microsoft.Data.SqlClient.SqlException : There is already an object named 'TestInAndOutParams' in the database.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ExecuteNonQueryCommand(String command) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\Batch\BatchTests.cs:line 667
   at Microsoft.Data.SqlClient.ManualTesting.Tests.BatchTests.ParameterInOutAndReturn() in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\Batch\BatchTests.cs:line 401
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
View more details on Azure Pipelines