Skip to content

Add configurable idle connection timeout (ADO #39970) #4295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
priyankatiwari08 wants to merge 5 commits into
base: main
Choose a base branch
from

Address PR #4295 inline review feedback

93ab7ee
Select commit
Loading
Failed to load commit list.
Open

Add configurable idle connection timeout (ADO #39970) #4295

Address PR #4295 inline review feedback
93ab7ee
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Package failed May 21, 2026 in 2h 50m 15s

Build #14106 had test failures

97 errors / 92 warnings

Details

Tests

  • Failed: 7 (0.00%)
  • Passed: 187,914 (96.46%)
  • Other: 6,893 (3.54%)
  • Total: 194,814

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 675 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

build.proj#L675 

build.proj(675,5): Error MSB3073: The command " "dotnet" test "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --collect "Code coverage" --settings "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/CodeCoverage.runsettings" --filter "category!=failing&category!=flaky&category!=interactive&category!=signed" -f net8.0 -p:TestSet="3" --results-directory "TestResults" --logger:"trx;LogFilePrefix=SqlClientManual-Windows_NT-net8.0-3" -p:ReferenceType=Package -p:AbstractionsPackageVersion=1.1.0-preview1ci14106 -p:LoggingPackageVersion=1.1.0-preview1ci14106 -p:SqlClientPackageVersion=7.1.0-preview1ci14106 -p:SqlServerPackageVersion=1.1.0-preview1ci14106 " exited with code 1.

Check failure on line 250 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L250 

Error: The process 'C:\hostedtoolcache\windows\dotnet\dotnet.exe' failed with exit code 1

Check failure on line 253 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Build log #L253 

Dotnet command failed with non-zero exit code on the following projects : [ 'D:\\a\\_work\\1\\s\\build.proj' ]

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(commandType: Text)

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(commandType: Text) 

Microsoft.Data.SqlClient.SqlException : The connection is broken and recovery is not possible.  The connection is marked by the client driver as unrecoverable.  No attempt was made to restore the connection.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.SqlConnection.ValidateAndReconnect(Action beforeDisconnect, Int32 timeout)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReaderTds(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, Boolean isAsync, Int32 timeout, Task& task, Boolean asyncWrite, Boolean isRetry, SqlDataReader ds, Boolean describeParameterEncryptionRequest)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, TaskCompletionSource`1 completion, Int32 timeout, Task& executeTask, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String method)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteReader(CommandBehavior cmdBehavior, RunBehavior runBehavior, Boolean returnStream, String method)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader(CommandBehavior behavior)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteReader()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.QuerySessionCounters(SqlConnection connection) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\MARSSessionPoolingTest\MarsSessionPoolingTest.cs:line 446
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.AssertSessionsAndRequests(SqlConnection connection, Int32 openMarsSessions, Int32 openRequests) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\MARSSessionPoolingTest\MarsSessionPoolingTest.cs:line 354
   at Microsoft.Data.SqlClient.ManualTesting.Tests.MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(CommandType commandType) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\MARSSessionPoolingTest\MarsSessionPoolingTest.cs:line 226
   at InvokeStub_MarsSessionPoolingTest.ExecuteReader_GarbageCollectReader(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithOneArg(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly 

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding.
Operation cancelled by user.
---- System.ComponentModel.Win32Exception : The wait operation timed out.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 343
   at InvokeStub_SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
----- Inner Stack Trace -----

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly 

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding.
Operation cancelled by user.
---- System.ComponentModel.Win32Exception : The wait operation timed out.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 343
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 310
   at InvokeStub_SqlVariantParameterTests.SqlType_TvpFromSqlDataReader_RoundTripsCorrectly(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
----- Inner Stack Trace -----

Check failure on line 1 in Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlMetaData_RoundTripsCorrectly

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package

Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlMetaData_RoundTripsCorrectly 

Microsoft.Data.SqlClient.SqlException : Execution Timeout Expired.  The timeout period elapsed prior to completion of the operation or the server is not responding.
Operation cancelled by user.
---- System.ComponentModel.Win32Exception : The wait operation timed out.
Raw output 
   at Microsoft.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.Connection.SqlConnectionInternal.OnError(SqlException exception, Boolean breakConnection, Action`1 wrapCloseInAction)
   at Microsoft.Data.SqlClient.TdsParser.ThrowExceptionAndWarning(TdsParserStateObject stateObj, SqlCommand command, Boolean callerHasConnectionLock, Boolean asyncClose)
   at Microsoft.Data.SqlClient.TdsParser.TryRun(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj, Boolean& dataReady)
   at Microsoft.Data.SqlClient.SqlCommand.RunExecuteNonQueryTds(String methodName, Boolean isAsync, Int32 timeout, Boolean asyncWrite)
   at Microsoft.Data.SqlClient.SqlCommand.InternalExecuteNonQuery(TaskCompletionSource`1 completion, Boolean sendToPipe, Int32 timeout, Boolean& usedCache, Boolean asyncWrite, Boolean isRetry, String methodName)
   at Microsoft.Data.SqlClient.SqlCommand.ExecuteNonQuery()
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlMetaData_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 300
   at Microsoft.Data.SqlClient.ManualTesting.Tests.SqlVariantParameterTests.SqlType_TvpFromSqlMetaData_RoundTripsCorrectly(Object paramValue, String expectedTypeName, String expectedBaseTypeName) in D:\a\_work\1\s\src\Microsoft.Data.SqlClient\tests\ManualTests\SQL\ParameterTest\SqlVariantParameterTests.cs:line 264
   at InvokeStub_SqlVariantParameterTests.SqlType_TvpFromSqlMetaData_RoundTripsCorrectly(Object, Span`1)
   at System.Reflection.MethodBaseInvoker.InvokeWithFewArgs(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
----- Inner Stack Trace -----
View more details on Azure Pipelines