Skip to content

Fix SPN using instance name instead of resolved port for Protocol.None and Protocol.Admin #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
paulmedynski wants to merge 3 commits into
base: main
Choose a base branch
from
+392 −6

Address Copilot review feedback: SPN safety, DNS isolation, and test …

d485228
Select commit
Loading
Failed to load commit list.
Draft

Fix SPN using instance name instead of resolved port for Protocol.None and Protocol.Admin #4180

Address Copilot review feedback: SPN safety, DNS isolation, and test …
d485228
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Package (Win22_Sql22_Named_Instance net8_0_AnyCPU_ManagedSNI_2) succeeded May 7, 2026 in 28m 56s

Win22_Sql22_Named_Instance net8_0_AnyCPU_ManagedSNI_2 succeeded

2 errors / 1 warnings

Annotations

Check failure on line 699 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package (Win22_Sql22_Named_Instance net8_0_AnyCPU_ManagedSNI_2)

build.proj#L699 

build.proj(699,5): Error MSB3073: The command " "dotnet" test "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --collect "Code coverage" --settings "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/CodeCoverage.runsettings" --filter "category!=failing&category!=flaky&category!=interactive" -f net8.0 -p:TestSet="2" --results-directory "TestResults" --logger:"trx;LogFilePrefix=SqlClientManual-Windows_NT-net8.0-2" -p:ReferenceType=Package -p:AbstractionsPackageVersion=1.0.0-ci12708 -p:LoggingPackageVersion=1.0.0-ci12708 -p:SqlClientPackageVersion=7.1.0-preview1ci12708 " exited with code 1.

Check failure on line 162 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Package (Win22_Sql22_Named_Instance net8_0_AnyCPU_ManagedSNI_2)

Build log #L162 

Process 'msbuild.exe' exited with code '1'.
View more details on Azure Pipelines