Skip to content

Fix TryOpenInner InvalidCast race and add unit regression tests (#3314) #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulmedynski merged 4 commits into from
May 12, 2026
+129 −5

Fix test naming clarity and exception snapshot consistency per Copilo…

b077628
Select commit
Loading
Failed to load commit list.
Merged

Fix TryOpenInner InvalidCast race and add unit regression tests (#3314) #4179

Fix test naming clarity and exception snapshot consistency per Copilo…
b077628
Select commit
Loading
Failed to load commit list.
Azure Pipelines / PR-SqlClient-Project (Win22_Azure_Sql net8_0_AnyCPU_ManagedSNI_2) succeeded Apr 29, 2026 in 18m 20s

Win22_Azure_Sql net8_0_AnyCPU_ManagedSNI_2 succeeded

3 errors / 1 warnings

Annotations

Check failure on line 0 in EXEC

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (Win22_Azure_Sql net8_0_AnyCPU_ManagedSNI_2)

EXEC#L0 

EXEC(0,0): Error Message:

Check failure on line 655 in build.proj

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (Win22_Azure_Sql net8_0_AnyCPU_ManagedSNI_2)

build.proj#L655 

build.proj(655,5): Error MSB3073: The command " "dotnet" test "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/ManualTests/Microsoft.Data.SqlClient.ManualTests.csproj" -p:Configuration=Debug --blame-hang --blame-hang-dump-type full --blame-hang-timeout 10m --collect "Code coverage" --settings "D:\a\_work\1\s\src\..\src/Microsoft.Data.SqlClient/tests/tools/Microsoft.Data.SqlClient.TestUtilities/CodeCoverage.runsettings" --filter "category!=failing&category!=flaky&category!=interactive" -f net8.0 -p:TestSet="2" --results-directory "TestResults" --logger:"trx;LogFilePrefix=SqlClientManual-Windows_NT-net8.0-2" -p:AbstractionsPackageVersion=1.0.0-ci11916 -p:LoggingPackageVersion=1.0.0-ci11916 -p:SqlClientPackageVersion=7.1.0-preview1ci11916 " exited with code 1.

Check failure on line 328 in Build log

See this annotation in the file changed.

@azure-pipelines azure-pipelines / PR-SqlClient-Project (Win22_Azure_Sql net8_0_AnyCPU_ManagedSNI_2)

Build log #L328 

Process 'msbuild.exe' exited with code '1'.
View more details on Azure Pipelines