Repository navigation
Conversation
README promised "PHP 5.3+", which was neither true (api.php calls http_response_code(), added in 5.4) nor safe: interpreter-level PHP bugs such as CVE-2026-109618 / CVE-2026-109619 (Oct 2026, unauthenticated RCE) fire while PHP parses the request, before api.php runs, and upstream ships no fix at all for 7.3 and older. Point users at php.net's supported branches (or a vendor package with backported fixes) instead of a version floor, and add a "Keep PHP patched" section explaining why this layout makes PHP part of websh's attack surface and what to do when a patched PHP isn't available.
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
http_response_code()needs 5.4) with "a supported branch or a vendor package that still gets security fixes" in README, README.ru and theapi.phpheader.docs/deployment.md: why this layout makes PHP part of websh's attack surface, why the proxy can't mitigate request-parsing bugs, and what to do without a patched PHP. Both Quick starts link to it.Motivation: CVE-2026-109618 / CVE-2026-109619 (Oct 2026) — unauthenticated RCE in the PHP interpreter during request handling; fixed in 8.2.35 / 8.3.36 / 8.4.27 / 8.5.12, no upstream fix for 7.3 and older.
Test plan:
php -l api.php;tests/php/smoke.shpasses; heading anchors checked.