chore: bump docker-model and llamacpp versions in build.json#843
Merged
ilopezluna merged 3 commits intomainfrom Apr 7, 2026
Merged
chore: bump docker-model and llamacpp versions in build.json#843ilopezluna merged 3 commits intomainfrom
ilopezluna merged 3 commits intomainfrom
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
doringeman
approved these changes
Apr 7, 2026
Contributor
doringeman
left a comment
There was a problem hiding this comment.
Just a thought: is it simpler to fetch latest and then use the tag with the same SHA as latest?
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider adding
--fail --show-error --max-timeflags to thecurlcall so that network or API failures cause the step to fail more explicitly rather than only relying on the post-jqnull/empty check. - The jq filter for selecting the llamacpp tag is fairly specific to the current tag naming scheme; adding a brief inline comment explaining the
latest-cpu/digest matching and^v[0-9]+\.[0-9]+\.[0-9]+-cpu$assumption would make future maintenance safer.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider adding `--fail --show-error --max-time` flags to the `curl` call so that network or API failures cause the step to fail more explicitly rather than only relying on the post-`jq` null/empty check.
- The jq filter for selecting the llamacpp tag is fairly specific to the current tag naming scheme; adding a brief inline comment explaining the `latest-cpu`/digest matching and `^v[0-9]+\.[0-9]+\.[0-9]+-cpu$` assumption would make future maintenance safer.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
…d loading GO version conditionally
38a992d to
4896faa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.