Skip to content

chore: bump docker-model and llamacpp versions in build.json#843

Merged
ilopezluna merged 3 commits intomainfrom
bump-llamacpp-on-release
Apr 7, 2026
Merged

chore: bump docker-model and llamacpp versions in build.json#843
ilopezluna merged 3 commits intomainfrom
bump-llamacpp-on-release

Conversation

@ilopezluna
Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

Copy link
Copy Markdown
Contributor

@doringeman doringeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a thought: is it simpler to fetch latest and then use the tag with the same SHA as latest?

@ilopezluna ilopezluna marked this pull request as ready for review April 7, 2026 10:30
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider adding --fail --show-error --max-time flags to the curl call so that network or API failures cause the step to fail more explicitly rather than only relying on the post-jq null/empty check.
  • The jq filter for selecting the llamacpp tag is fairly specific to the current tag naming scheme; adding a brief inline comment explaining the latest-cpu/digest matching and ^v[0-9]+\.[0-9]+\.[0-9]+-cpu$ assumption would make future maintenance safer.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider adding `--fail --show-error --max-time` flags to the `curl` call so that network or API failures cause the step to fail more explicitly rather than only relying on the post-`jq` null/empty check.
- The jq filter for selecting the llamacpp tag is fairly specific to the current tag naming scheme; adding a brief inline comment explaining the `latest-cpu`/digest matching and `^v[0-9]+\.[0-9]+\.[0-9]+-cpu$` assumption would make future maintenance safer.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ilopezluna ilopezluna force-pushed the bump-llamacpp-on-release branch from 38a992d to 4896faa Compare April 7, 2026 11:53
@ilopezluna ilopezluna merged commit 388a9fd into main Apr 7, 2026
24 of 25 checks passed
@ilopezluna ilopezluna deleted the bump-llamacpp-on-release branch April 7, 2026 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants