progress: replace hashstructure with explicit warning comparison - #4076
Draft
crazy-max wants to merge 1 commit into
Draft
progress: replace hashstructure with explicit warning comparison#4076crazy-max wants to merge 1 commit into
crazy-max wants to merge 1 commit into
Conversation
Deduplicate warnings without mutating their source definitions and preserve the order of first occurrences. Remove the hashstructure dependency and add coverage for warning equality and input preservation. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning deduplication currently clears
SourceInfo.Definitionon a shallow copy, which also modifies the original warning through the shared pointer. Replace reflection-based hashing with explicit comparison so deduplication ignores vertex and source definitions without modifying its inputs.This also removes the archived
hashstructuredependency and preserves the order of first occurrences.