docker-container: give readiness wait a full startup timeout - #4050
Merged
crazy-max merged 2 commits intoSep 10, 2026
Conversation
A recently started builder should use its StartedAt timestamp to decide whether BuildKit may still be coming up, but not as the absolute deadline for the client readiness wait. When the first client request arrived near the end of that startup window, the wait could inherit only a few milliseconds and fail with DeadlineExceeded even though the builder was still legitimately starting. Give those recent containers a fresh bounded wait from the current time while continuing to skip the wait for established builders. Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Member
Author
|
Encounter this error quite often in actions-toolkit integration tests: https://github.com/docker/actions-toolkit/actions/runs/34329830393/job/102395668163?pr=1309#step:10:752 |
Use the container start time only to decide whether readiness waiting is needed. Start a full timeout immediately before waiting so Docker dial time does not consume the readiness budget. Name the startup window and readiness timeout independently, and cover the exact startup-window boundary. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to https://github.com/docker/buildx/actions/runs/33654939933/job/100331039441#step:7:2387
A recently started builder should use its
StartedAttimestamp to decide whether BuildKit may still be coming up, but not as the absolute deadline for the client readiness wait.When the first client request arrived near the end of that startup window, the wait could inherit only a few milliseconds and fail with DeadlineExceeded even though the builder was still legitimately starting. Give those recent containers a fresh bounded wait from the current time while continuing to skip the wait for established builders.